geerlingguy / ansible-role-firewall

Ansible Role - iptables Firewall configuration.
https://galaxy.ansible.com/geerlingguy/firewall/
MIT License
524 stars 217 forks source link

Defaults: Use ansible_port if defined instead of 22 #78

Closed nununo closed 3 years ago

nununo commented 3 years ago

Make firewall_allowed_tcp_ports more flexible by using ansible_port if defined and falling back to 22 if not.

This is a proposal to implement issue #76 which I submitted.

I'm not very familiar with jinja2 templates so there may be a simpler way to implement it instead of the if else...

stale[bot] commented 3 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 3 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.