geerlingguy / ansible-role-jenkins

Ansible Role - Jenkins CI
https://galaxy.ansible.com/geerlingguy/jenkins/
MIT License
830 stars 746 forks source link

Fix plugin updates metadata URL #372

Closed L-Eugene closed 9 months ago

L-Eugene commented 1 year ago

The replace part of plugin installation tasks doesn't seems to work. I see such logs when trying to install plugins with this role. I've tested the replace task alone and it is never remove the lines.

Jan  1 11:08:22 jenkins ansible-get_url: Invoked with url=https://updates.jenkins.io/update-center.json dest=/var/lib/jenkins/updates/default.json owner=jenkins group=jenkins mode=288 force=False http_agent=ansible-httpget use_proxy=True validate_certs=True force_basic_auth=False use_gssapi=False backup=False sha256sum= checksum= timeout=10 unredirected_headers=[] unsafe_writes=False url_username=None url_password=NOT_LOGGING_PARAMETER client_cert=None client_key=None headers=None tmp_dest=None seuser=None serole=None selevel=None setype=None attributes=None
Jan  1 11:08:35 jenkins ansible-replace: Invoked with path=/var/lib/jenkins/updates/default.json regexp=1d;$d replace= backup=False encoding=utf-8 unsafe_writes=False after=None before=None validate=None mode=None owner=None group=None seuser=None serole=None selevel=None setype=None attributes=None
Jan  1 11:08:43 jenkins jenkins[10459]: 2023-01-01 11:08:43.121+0000 [id=13]#011SEVERE#011hudson.model.UpdateSite#getJSONObject: Failed to parse /var/lib/jenkins/updates/default.json
Jan  1 11:08:43 jenkins jenkins[10459]: net.sf.json.JSONException: A JSONObject text must begin with '{' at character 1 of updateCenter.post(

Moreover, the same result may be reached by simply requesting file in JSON format from updates server as described in Jenkins update center documentation

rds13 commented 1 year ago

👍

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

L-Eugene commented 1 year ago

@geerlingguy, is there any chance to include this in upstream?

github-actions[bot] commented 11 months ago

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] commented 9 months ago

This pr has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.