Issue #223: Generate a random default root password

geerlingguy / ansible-role-mysql

Ansible Role - MySQL

https://galaxy.ansible.com/geerlingguy/mysql/

MIT License

1.05k stars 866 forks source link

Issue #223: Generate a random default root password #465

Open colans opened 3 years ago

colans commented 3 years ago

Instead of hard-coding an insecure default password for the root MySQL user, generate a random one as discussed in issue #223.

This is more complicated than simply adding a random password to the defaults file because that'll change every time the variable is read. Instead, I generate a random password and place it into /root/.my.cnf (or wherever) unless there already is one, fetch it from there, and then use it to set the actual root password in the DB. But this only happens if the configuration file has changed. Otherwise, they'd be out of sync.

colans commented 3 years ago

I can't figure out how to turn this comment in to a new "conversation" or start my own review (as I'm more familiar with GitLab) so please convert if you can...

That test result is failing for MySQL < 5.7. I'm less concerned about that because support for that ended in February. Is there a way we could skip that one (for the time being, at least), and see how it works for 5.7+? I'm actually testing this myself on v8, and not having any problems (Ubuntu 20.04).