geerlingguy / ansible-role-mysql

Ansible Role - MySQL
https://galaxy.ansible.com/geerlingguy/mysql/
MIT License
1.05k stars 866 forks source link

Fix idempotence for Debian 11 and Debian 10 tests #478

Closed geerlingguy closed 2 years ago

geerlingguy commented 2 years ago

It seems that #457 may have broken idempotence on Debian 10. Testing to see if that's the case. Don't want to tag broken code in a new release...

geerlingguy commented 2 years ago

Heh... so idempotence breaks on debian 10 without the change, but breaks on debian 11 with the change. Drat.

geerlingguy commented 2 years ago

What is that check even for? Maybe a better check is needed. It's been a while, but I think it's checking for an initv script... which is probably not even a thing on Debian 11.

ak4t0sh commented 2 years ago

FYI just checked on a fresh install it seems that the file has been renamed to /etc/init.d/mariadb on debian11

geerlingguy commented 2 years ago

@ak4t0sh - So in that case, it needs to check for a file named mysql in debian 10, but mariadb in debian 11... or we need to figure out a better idempotence check.