search

geerlingguy / ansible-role-mysql

Ansible Role - MySQL
https://galaxy.ansible.com/geerlingguy/mysql/
MIT License
1.05k stars 861 forks source link

Hide passwords during execution #532

Closed ghost closed 9 months ago

ghost commented 9 months ago

Hi,

This small pull request allows user to hide current plain-text passwords into execution output with the new variable mysql_hide_passwords. The default value of this variable is false to allow users to activate this feature if they need it with a minimal impact on their current usage.

Thank you.

ghost commented 9 months ago

Closing/Reopening was the only way I found to trigger tests again.

ghost commented 9 months ago

Hi,

I created another branch for CI into my forked repository: https://github.com/ptomas-adacis/ansible-role-mysql/commits/run_ci

The CI workflow is failing because of this known ansible bug: https://github.com/ansible/ansible/issues/82264

The last commit of my branch (https://github.com/ptomas-adacis/ansible-role-mysql/commit/355fb248560a30799ca8018c1493768d4b9b556b) is applying this workaround: https://github.com/ansible/ansible/issues/82264#issuecomment-1822308328 to run the CI workflow without triggering the ansible bug.

As you can see here: https://github.com/ptomas-adacis/ansible-role-mysql/actions/runs/7099722877 the CI workflow is now running successfully.

Thank you

geerlingguy commented 9 months ago

Can you add that fix to this PR and I'll merge it? (ping me if I forget!)