Allow to specify exact nodejs version to install

geerlingguy / ansible-role-nodejs

Ansible Role - Node.js

https://galaxy.ansible.com/geerlingguy/nodejs/

MIT License

410 stars 252 forks source link

Allow to specify exact nodejs version to install #135

Closed piotrkochan closed 1 year ago

piotrkochan commented 2 years ago

By default, ansible-role-nodejs always installs latest nodejs version. Actually, it upgrades it to the latest version on every run which may cause some problems in production environment.

This PR adds the option to choose the exact nodejs version to install. It doesn't change default behavior of the role.

diogopms commented 2 years ago

@geerlingguy, can we merge this code? Thanks 🙏🏻 I would like to support node v16

geerlingguy commented 2 years ago

Wouldn't just adding something like nodejs_version: '16.15.0-' work here? since the other task includes the * and only replaces x in the version string?

piotrkochan commented 2 years ago

It is possible to extract major version from the nodejs_version, glue additional .x and use it to configure the repository.

nad56 commented 1 year ago

Could it be done also for the redhat part? Wouldn't something like this be enough?

name: Ensure Node.js and npm are installed. yum: name: "nodejs-{{ nodejs_exact_version|default(nodejs_version|regex_replace('x', '')) }}*" state: present enablerepo: nodesource

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 1 year ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.