search

geerlingguy / ansible-role-nodejs

Ansible Role - Node.js
https://galaxy.ansible.com/geerlingguy/nodejs/
MIT License
410 stars 252 forks source link

NodeSource Repository Update #155

Closed oxzi closed 6 months ago

oxzi commented 9 months ago

The old NodeSource repository is no longer updated. The new "nodistro" suite should now be used instead to receive future updates. This was already addressed in both #153 and #154 and merging this would close this two issues.

This Pull Request builds on top of #152 and contains two commits, one from @MohamedLamineAllal to switch from the old apt_key to deb822_repository and one from me to switch to the new repository. As this PR wraps @MohamedLamineAllal's changes, merging this would allow closing the other one.

Please note: I have tested the Debian setup successfully with Node.js version "18.x" and "20.x". The RedHat setup, however, was not tested as I do not have any RedHat-based systems laying around.

zane-carter commented 9 months ago

Thankyou!

oliverhabara commented 7 months ago

Hi, can this be merged?

neilyoung commented 6 months ago

Please merge

misilot commented 6 months ago

@geerlingguy any chance we could get this and #152 merged?

geerlingguy commented 6 months ago

Merged! After tests pass I'll tag a new release. Thanks!

geerlingguy commented 6 months ago

Looks like tests are failing now—I've opened #158 as a follow-up, right now I might not have time to look into it, but here's the error message when running under Debian 11:

 TASK [geerlingguy.nodejs : Add NodeSource repositories for Node.js.] ***********
  An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ModuleNotFoundError: No module named 'debian'
  fatal: [instance]: FAILED! => {"changed": false, "msg": "Failed to import the required Python library (python3-debian) on instance's Python /usr/bin/python3. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"}