geerlingguy / ansible-role-nodejs

Ansible Role - Node.js
https://galaxy.ansible.com/geerlingguy/nodejs/
MIT License
410 stars 252 forks source link

Failing CI tests on Debian 11 after updating NodeSource repos #158

Closed geerlingguy closed 6 months ago

geerlingguy commented 6 months ago

After merging #155 I'm seeing the following error in CI:

 TASK [geerlingguy.nodejs : Add NodeSource repositories for Node.js.] ***********
  An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ModuleNotFoundError: No module named 'debian'
  fatal: [instance]: FAILED! => {"changed": false, "msg": "Failed to import the required Python library (python3-debian) on instance's Python /usr/bin/python3. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"}

I would like to get this resolved prior to releasing a new version of this role, so we don't break anything for those using older versions of Debian.

geerlingguy commented 6 months ago

Ah... looks like the deb822_repository module requires one of python3-debian or python-debian.

geerlingguy commented 6 months ago

Now getting in Rocky Linux:

in add_remote_rpms
    raise IOError(_(\"Could not open: {}\").format(' '.join(pkgs_error)))
OSError: Could not open: /root/.ansible/tmp/ansible-tmp-1708465612.5267463-2640-266119115545335/nodesource-release-nodistro-1.noarchyvw31e31.rpm

Looks like the format should be: https://rpm.nodesource.com/pub_20.x/nodistro/repo/nodesource-release-nodistro-1.noarch.rpm

geerlingguy commented 6 months ago

Heh, and now:

fatal: [instance]: FAILED! => {"changed": false, "msg": "Failed to validate GPG signature for nodesource-release-nodistro-1.noarch: Public key for nodesource-release-nodistro-1.noarchxuebiwbj.rpm is not installed"}
geerlingguy commented 6 months ago

Fixed now!

misilot commented 6 months ago

Thank you @geerlingguy!

oxzi commented 6 months ago

Thanks for merging and taking care of both the tests and the RHEL stuff :)