geerlingguy / ansible-role-ntp

Ansible Role - NTP
https://galaxy.ansible.com/geerlingguy/ntp/
MIT License
318 stars 241 forks source link

Adapt the chrony config template to use pool instead of server directive #113

Closed mikevo closed 1 year ago

mikevo commented 2 years ago

Similar to #77 chrony supports the pool directive since version 2.0 (see chrony-2.0 released). This version is quite old (2015) and hence the directive should be supported by all major OS.

This change will ensure, that both ntp and chrony are able to consume the configured ntp_servers as pool servers. Currently, there is a difference when the specified DNS name specified as server gets resolved to multiple IPs. With the pool directive all can be utilized (as already specified for ntp).

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

mikevo commented 1 year ago

Reading the blog post linked in the message send by the stale bot I guess there is no viable option to get the currently open PRs merged even though I think this PR would fall into the no-brainer category as it is already implemented for the ntp config?

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 1 year ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.