geerlingguy / ansible-role-ntp

Ansible Role - NTP
https://galaxy.ansible.com/geerlingguy/ntp/
MIT License
318 stars 241 forks source link

update README.md - missing community.general in Requirements #115

Closed nayodahl closed 1 year ago

nayodahl commented 2 years ago

I think the readme is outdated, there is no "community.general" in Requirements.

When I try to ansible-lint a playbook using geerlingguy/ntp, I get the following error :

../../../../home/runner/.cache/ansible-compat/70d583/roles/geerlingguy.ntp/tasks/main.yml:36:3: syntax-check: couldn't resolve module/action 'timezone'. This often indicates a misspelling, missing collection, or incorrect module path.

in tasks/main :

- name: Set timezone.
  timezone:
    name: "{{ ntp_timezone }}"
  notify: restart cron

Indeed, the timezone command does not exist unless you install community.general, according to this doc : https://docs.ansible.com/ansible/latest/collections/community/general/timezone_module.html

stale[bot] commented 1 year ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

jwarnier commented 1 year ago

I believe the meta should also be updated if/when this is fixed in the README.md.

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

stale[bot] commented 1 year ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.