search

geerlingguy / ansible-role-ntp

Ansible Role - NTP
https://galaxy.ansible.com/geerlingguy/ntp/
MIT License
319 stars 243 forks source link

Generate config file before starting/stopping the service #76

Closed m8ram closed 4 years ago

m8ram commented 4 years ago

The config file is generated/deployed after the service is started.

Is it not better to move the task "Ensure NTP is running and enabled as configured." to the end of task.yml?

Stopping/disabling the service before deploying might make sense. but if the config file contains an error the service start will fail and the playbook will not reach the point where the config file is updated. And if the default file contains incorrect values starting it before the file is reconfigured might trigger undesired changes to the system time.

stale[bot] commented 4 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] commented 4 years ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.