additional operating system for the role

vmpr commented 4 years ago

Hi Jeff, I am maintaining a lot of hypervisor hosts and they are a bit different to normal operating systems. In that case, it's XCP-ng, which is an (awesome) fork of XenServer and Xenserver sits on top of centos. My problem is that when you check for 'ansible_os_family' my Server will not give you back 'RedHat' it will tell you that it is "ansible_os_family": "XCP-ng",

at the moment I've fixed that like:

  roles:
    # role to manage ntp/chrony
    - role: geerlingguy.ntp
      vars:
        ansible_os_family: 'RedHat'

but I would like to bring the XCP-ng OS in your role. it is actually an centos7 so it needs exactly the variable file which RedHat is using:

that should do the trick:

- name: Include OS-specific variables for XCP-ng.
  include_vars: RedHat.yml
  when:
    - ansible_os_family == 'XCP-ng'

so we don't need another File in the vars directory with the same values like RedHat.yml

I am happy to do a PR if that's the way you prefer or do you have a better idea? thanks!

stale[bot] commented 4 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

vmpr commented 4 years ago

I would like to fix that issue for everyone, will you merge a PR? I know everyone is busy especially with all your youtube recording, but three issues I've filed just got staled - would be nice to fix them!

stale[bot] commented 4 years ago

This issue is no longer marked for closure.