geerlingguy / ansible-role-ntp

Ansible Role - NTP
https://galaxy.ansible.com/geerlingguy/ntp/
MIT License
319 stars 243 forks source link

Ensure the configuration file is updated before attempting to start the service #93

Closed m8ram closed 3 years ago

m8ram commented 3 years ago

Fixes issue #76 .

The issue was closed due to inactivity so I'm hoping that a pull request will make it easier to get this fixed. This change ensures that if the service is stopped due to a configuration error it can be started after the error has been resolved.

smbambling commented 3 years ago

I do agree that the ordering here is a bit strange and I don't disagree with this update. I just wanted to point out that the updated config will get applied at the end of the Playbook run via the handle as the task include notify: restart ntp

stale[bot] commented 3 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 3 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.