search

geerlingguy / ansible-role-php-versions

Ansible Role - PHP Versions
https://galaxy.ansible.com/geerlingguy/php-versions/
MIT License
98 stars 73 forks source link

Fix apt module loop to avoid deprecation notices #37

Closed m-demoraes closed 5 years ago

m-demoraes commented 5 years ago

[DEPRECATION WARNING]: Invoking "apt" only once while using a loop via squash_actions is deprecated. Instead of using a loop to supply multiple items and specifying name: "{{ item }}", please use name: ['php5.6-common', 'php7.0-common', 'php7.1-common', 'php7.2-common', 'php7.3-common'] and remove the loop. This feature will be removed in version 2.11. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

geerlingguy commented 5 years ago

Ooh, that's a creative way to solve this, had not thought of reject().

I like it.

geerlingguy commented 5 years ago

Made one additional tweak for the variable style.