geerlingguy / ansible-role-php-versions

Ansible Role - PHP Versions
https://galaxy.ansible.com/geerlingguy/php-versions/
MIT License
98 stars 73 forks source link

Add variable to toggle removal of older PHP verions #40

Closed kindlehl closed 4 years ago

kindlehl commented 5 years ago

My organization finds it very useful to run two versions of PHP-FPM. This role nearly accomplishes this goal, but the purge task in setup-Debian.yml stops that from working for us.

Would you be willing to allow a when condition to be added to toggle that task? Maybe call it php_remove_old_versions? Not sure how this would work for the RedHat side of things, though.

geerlingguy commented 5 years ago

It would definitely cause issues on the RedHat side, so maybe if this were added, it would be a Debian/Ubuntu-only deal.

stale[bot] commented 4 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] commented 4 years ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

gesof commented 1 year ago

I subscribe to adding a condition to avoid purging. You mentioned about issues with RedHat: it is their issue not an Ubuntu/Debian-only deal. It is more and more common to run multiple PHP versions on one machine.