search

geerlingguy / ansible-role-php-versions

Ansible Role - PHP Versions
https://galaxy.ansible.com/geerlingguy/php-versions/
MIT License
98 stars 73 forks source link

Redhat distro family support for PHP version switch #50

Closed mhitza closed 3 years ago

mhitza commented 4 years ago

For the test, I've used the poorly documented molecule side-effect feature. It gets called by molecule test after the idempotency step.

Would you like me to wrap this specific change within a block, as it is the case with the dnf module-specific code in setup-RedHat.yml?

Since I'm referencing that block section which is enabled for versions of RedHat >=8, I might add changes for the default docker image to be cento8 (instead of centos7) and change the role meta information to state explicitly that it works with EL version 8 or higher?

Because there is no support for CentOS 7, the side-effect test will fail. Would you like me to remove centos7 from the Travis test matrix, or add a conditional for RedHat >=8 in the assertion block?

MacFlurry commented 4 years ago

Hello @mhitza ,

is your PR resolve this issue https://github.com/geerlingguy/ansible-role-php-versions/issues/52 ?

Thanks

mhitza commented 4 years ago

@MacFlurry indeed, that's the issue it's fixing.

MacFlurry commented 4 years ago

thanks a lot @mhitza , I hope @geerlingguy will merge it quickly :-)

geerlingguy commented 4 years ago

@mhitza - I'd leave the centos/rhel 8 specific dnf changes in a block, and I'd accept it at that point. I'm okay with not having everything work in 7/6 since this is new functionality.

mhitza commented 4 years ago

@geerlingguy not sure if there is anything you'd want me to change in this PR.

stale[bot] commented 3 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 3 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.