search

geerlingguy / ansible-role-php-versions

Ansible Role - PHP Versions
https://galaxy.ansible.com/geerlingguy/php-versions/
MIT License
98 stars 73 forks source link

Remove explicit dependency on php-json #76

Closed kravietz closed 2 years ago

kravietz commented 2 years ago

This prevents the role from working on Ubuntu 20.04 with PHP 8.1 per:

# apt install php8.1-json
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Package php8.1-json is a virtual package provided by:
  php8.1-phpdbg 8.1.2-1+ubuntu20.04.1+deb.sury.org+1
  php8.1-fpm 8.1.2-1+ubuntu20.04.1+deb.sury.org+1
  php8.1-cli 8.1.2-1+ubuntu20.04.1+deb.sury.org+1
  php8.1-cgi 8.1.2-1+ubuntu20.04.1+deb.sury.org+1
  libphp8.1-embed 8.1.2-1+ubuntu20.04.1+deb.sury.org+1
  libapache2-mod-php8.1 8.1.2-1+ubuntu20.04.1+deb.sury.org+1
You should explicitly select one to install.

E: Package 'php8.1-json' has no installation candidate
geerlingguy commented 2 years ago

For users of PHP < 8.1, this would be a breaking change, since it's removing a package that might be relied upon to be in the defaults. I would rather recommend users override the list in their own playbook vars for now, and once we switch the default to PHP 8.1, we can make this change the default.

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 2 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.