geerlingguy / ansible-role-php-xhprof

Ansible Role - PHP XHProf
https://galaxy.ansible.com/geerlingguy/php-xhprof/
MIT License
13 stars 17 forks source link

Missing xhprof_html assets in PECL installation #11

Closed oxyc closed 8 years ago

oxyc commented 8 years ago

See https://github.com/phacility/xhprof/issues/64, https://github.com/geerlingguy/drupal-vm/issues/91 and https://bugs.php.net/bug.php?id=65992.

Doesnt seem likely this will be fixed upstream. Guess there are two options:

  1. Install from source https://github.com/phacility/xhprof/blob/master/xhprof_html/docs/index.html#L289:L294
  2. Fetch the assets from github and extract them into xhprof_html

If we go with 1 this could also be made to solve #2.

geerlingguy commented 8 years ago

:(

Yeah, I was just thinking about this a couple weeks ago. I'm thinking we go with source install. We can model the source install after the almost-identical install for php-xdebug https://github.com/geerlingguy/ansible-role-php-xdebug

geerlingguy commented 8 years ago

Fixed in #12