search

geerlingguy / ansible-role-php

Ansible Role - PHP
https://galaxy.ansible.com/geerlingguy/php/
MIT License
496 stars 441 forks source link

Use comment filter on ansible_managed var in www.conf #334

Closed dannycobussen closed 2 years ago

dannycobussen commented 3 years ago

When setting ansible_managed to a multiline value, the default www-pool file becomes invalid. I've added the comment filter with a custom decoration.

stale[bot] commented 3 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

gotmax23 commented 3 years ago

I see no reason not to merge this change.

stale[bot] commented 3 years ago

This issue is no longer marked for closure.

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

dannycobussen commented 2 years ago

@geerlingguy do you want to merge this?

stale[bot] commented 2 years ago

This issue is no longer marked for closure.

geerlingguy commented 2 years ago

@dannycobussen - I've never set ansible_managed to anything more than a small bit of marker text, so never ran into a use case where it would span multiple lines. But I see no big deal with adding the extra jinja here to ensure multiline comments will work. Still seems strange to me, but I know some places are more particular about file headers.