Allow php_opcache to have any number of extra options

geerlingguy / ansible-role-php

Ansible Role - PHP

https://galaxy.ansible.com/geerlingguy/php/

MIT License

496 stars 441 forks source link

Allow php_opcache to have any number of extra options #346

Closed laurentdavid closed 2 years ago

laurentdavid commented 3 years ago

When configuring opcache we might need to have additional settings that are not necessary in the original list of default options (see https://www.php.net/manual/fr/opcache.configuration.php)

Use a dictionary instead of a fixed set of opcache options
Add the default php_opcache_defaults values
Ensure we have a default value for php_opcache dictionary

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

piotrkochan commented 2 years ago

I'm just putting/overriding extra opcache settings in conf.d directory, that way I don't need to change anything in the role.

stale[bot] commented 2 years ago

This issue is no longer marked for closure.

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 2 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.