search

geerlingguy / ansible-role-php

Ansible Role - PHP
https://galaxy.ansible.com/geerlingguy/php/
MIT License
496 stars 441 forks source link

Add pm.status_path to settings and template #351

Closed doenietzomoeilijk closed 2 years ago

doenietzomoeilijk commented 2 years ago

Adding a PR to #350 just in case. ;)

This should allow you to set a pm.status_path for an FPM pool. Leaving it empty should, per the documentation, disable the feature for that pool.

Open to comments and suggestions, I'm not too experienced with Ansible templating.

Closes #350

shakalandy commented 2 years ago

Thanks @doenietzomoeilijk! Sounds like a reasonable add-on, what do you think @geerlingguy ?

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

doenietzomoeilijk commented 2 years ago

I really hope this could still be picked up at some point, or if it's not up to snuff, explicitly closed.

stale[bot] commented 2 years ago

This issue is no longer marked for closure.

shakalandy commented 2 years ago

Hey @geerlingguy - would be really cool to have this one merged - thx!

geerlingguy commented 2 years ago

Please see my comment on https://github.com/geerlingguy/ansible-role-php/issues/350#issuecomment-1073316880 — I think that would be more flexible for these types of settings that aren't commonly used by most PHP installations.