search

geerlingguy / ansible-role-php

Ansible Role - PHP
https://galaxy.ansible.com/geerlingguy/php/
MIT License
492 stars 442 forks source link

Fix variable name for pm.max_requests. #352

Closed doenietzomoeilijk closed 1 year ago

doenietzomoeilijk commented 2 years ago

While combing through the options, I encountered this default with a "wrong" name. This would result in pools not getting the for-all-pools value set for pm.max_requests, instead falling back to the default 500.

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

doenietzomoeilijk commented 2 years ago

I really hope this could still be picked up at some point, or if it's not up to snuff, explicitly closed.

stale[bot] commented 2 years ago

This issue is no longer marked for closure.

vdwijngaert commented 2 years ago

This PR needs some attention indeed, it fixes an issue where you can't override the default www pool max_requests. Workaround is to completely redefine the pool in its entirety, which isn't always what you want... 🤷

See #345 as well

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

racke commented 1 year ago

Bump

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 1 year ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.