search

geerlingguy / ansible-role-php

Ansible Role - PHP
https://galaxy.ansible.com/geerlingguy/php/
MIT License
492 stars 442 forks source link

Allow extra settings per pool, fix #350 #367

Closed steinbrueckri closed 3 months ago

shakalandy commented 2 years ago

Could you please take a look at this one @geerlingguy ? It's a follow up from the discussion in #350 - thanks!

BapRx commented 2 years ago

Hey @geerlingguy sorry to bother you, if those changes look OK for you, could you please merge and tag a new version? Thanks!

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

steinbrueckri commented 1 year ago

Bump

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

steinbrueckri commented 1 year ago

Bump

stale[bot] commented 1 year ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

steinbrueckri commented 1 year ago

Bump

stale[bot] commented 1 year ago

This pull request is no longer marked for closure.

geerlingguy commented 1 year ago

Re-testing

steinbrueckri commented 1 year ago

Ok will check asap 🙇‍♂️

geerlingguy commented 1 year ago

Still getting some fails :(

steinbrueckri commented 1 year ago

@geerlingguy Finally I was able to find the "Bug".

steinbrueckri commented 1 year ago

@geerlingguy What is not the way to go? You merged #395 before this PR. In my option, PR #367 is more flexible then #395. But know there are merge conflicts? How should I deal with this or do you just want to close this PR?

github-actions[bot] commented 10 months ago

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

steinbrueckri commented 10 months ago

@geerlingguy What is not the way to go? You merged #395 before this PR. In my option, PR #367 is more flexible then #395. But know there are merge conflicts? How should I deal with this or do you just want to close this PR?

?

github-actions[bot] commented 5 months ago

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] commented 3 months ago

This pr has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.