search

geerlingguy / ansible-role-php

Ansible Role - PHP
https://galaxy.ansible.com/geerlingguy/php/
MIT License
492 stars 442 forks source link

Remove unused pools #370

Closed DirkBlade closed 1 year ago

DirkBlade commented 2 years ago

I renamed a pool and the previous pool was not removed causing fpm to fail to restart as ports conflicted.

I assume any file left in the pool.d folder will be left alone, whilst this is sometimes desirable it can lead to undetermined state. Currently there will have to be a manual rollback or additional task if pools are removed.

Would be nice is there was a config option to purge all pools after Ensure the default pool directory exists. but before Create fpm pools. so the resultant pools are always consistent with the yml.

Alternatively, or additionally, a state: absent parameter on pools would allow dictating the removal of old or renamed pools.

Is it worth my doing a PR?

stale[bot] commented 2 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] commented 1 year ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.