geerlingguy / ansible-role-php

Ansible Role - PHP
https://galaxy.ansible.com/geerlingguy/php/
MIT License
492 stars 442 forks source link

Add php_fpm_pool_listen_user and php_fpm_pool_listen_group #388

Closed duviful closed 1 year ago

duviful commented 1 year ago

Add the ability to specify listen.owner and listen.group, which can be distinct from user and group. As seen in issue #378

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

dlundgren commented 1 year ago

Ideally this should be using {{ item.pool_listen_user | default(php_fpm_pool_listen_user) }} and {{ item.pool_listen_group | default(php_fpm_pool_listen_group) }}, so that we can specify these individually per pool, as it is right now, I have to manage the fpm pools independently because I can't specify the user per pool.

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

shakalandy commented 1 year ago

can we get this one merged, please @geerlingguy?