search

geerlingguy / ansible-role-php

Ansible Role - PHP
https://galaxy.ansible.com/geerlingguy/php/
MIT License
496 stars 442 forks source link

fix with_flattened #397

Closed BartOpitz closed 1 year ago

BartOpitz commented 1 year ago

Current Ansible version that is for example in AWX does not have with_flattened anymore. The fix is rather simple, but i would recommend that you check your other (great) ansible roles too.

BTW i have also corrected module names to fully qualified names, as recommended by current ansible-lint - at least for this file only. Hope this will be OK.

Ps. I wondered if for those variables we need to flatten at all, since those are plain, non-nested lists and you use them inside {{}} brackets. Anyway i did apply flatten as it won't hurt.

Ps. really great set of ansible roles - very well thought.

geerlingguy commented 1 year ago

Better to leave the flattening in place, I can't recall exactly why I used it but there was probably a reason lol.