geerlingguy / ansible-role-redis

Ansible Role - Redis
https://galaxy.ansible.com/geerlingguy/redis/
MIT License
254 stars 197 forks source link

Fix #46: Add update cache for debian setup #48

Closed walbertus closed 3 years ago

walbertus commented 4 years ago

This role failed to install Redis on a fresh Debian machine.

andyshinn commented 4 years ago

What about cache_valid_time configured via default variable?

stale[bot] commented 4 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

walbertus commented 4 years ago

Can you give an example? @andyshinn This PR will be considered stale without reviewed by the owner 😞

stale[bot] commented 4 years ago

This issue is no longer marked for closure.

andyshinn commented 4 years ago

I am suggesting something like:

--- ---
- name: Ensure Redis is installed.  - name: Ensure Redis is installed.
  apt:    apt:
    name: "{{ redis_package }}"     name: "{{ redis_package }}"
    state: present
    cache_valid_time: "{{ redis_cache_valid_time }}"

Then in vars/Debian.yml:

redis_cache_valid_time: 800

The redis_cache_valid_time will do the same as update_cache but will ignore updating if it has been done already recently (such as from another role or task).

stale[bot] commented 4 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 3 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.