search

geerlingguy / ansible-role-redis

Ansible Role - Redis
https://galaxy.ansible.com/geerlingguy/redis/
MIT License
254 stars 197 forks source link

Add stop-writes-on-bgsave-error to config #70

Closed widhalmt closed 2 years ago

widhalmt commented 2 years ago

The Change to README.md should explain why this helps. It's especially important when using Redis in connection with Logstash.

@geerlingguy I'm re-issueing this Pull-Request from another ogranization. We need this change for a customer so we'll try to have a branch that's as close as possible to upstream and only incorporate the changes we really need.

We don't want to put pressure on anyone and we totally understand that incorporating contributions takes it's time. So we try to contribute as much as we can and simultanously try to get a way to use changes we need right now without breaking compatibility to upstream.

geerlingguy commented 2 years ago

Instead of adding an extra config line that's useful in a few cases, I decided to add a new option that allows one or more extra config lines to the end of the config file: https://github.com/geerlingguy/ansible-role-redis/pull/71

So you could achieve the same thing here with:

redis_extra_config: |-
  redis_stop_writes_on_bgsave_error true
widhalmt commented 2 years ago

Ah, ok! Thank you very much. That will be very useful and safe us a lot of changes in the future!