search

geerlingguy / ansible-role-repo-epel

Ansible Role - EPEL Repository for RHEL/CentOS
https://galaxy.ansible.com/geerlingguy/repo-epel/
MIT License
186 stars 148 forks source link

Tests are not actually testing the role #46

Closed cognifloyd closed 3 years ago

cognifloyd commented 4 years ago

In Travis, it looks like whatever Docker is used for CentOS 8, 7, and 6 already has EPEL:

    TASK [geerlingguy.repo-epel : Check if EPEL repo is already configured.] *******
    ok: [instance]

    TASK [geerlingguy.repo-epel : Import EPEL GPG key with fingerprint safety check (ansible >= 2.9).] ***
    skipping: [instance]

    TASK [geerlingguy.repo-epel : Import EPEL GPG key (ansible < 2.9).] ************
    skipping: [instance]

    TASK [geerlingguy.repo-epel : Install EPEL repo.] ******************************
    skipping: [instance]

    TASK [geerlingguy.repo-epel : Disable Main EPEL repo.] *************************
    skipping: [instance]

So, we might need a different docker image or remove EPEL in a molecule prepare playbook.

geerlingguy commented 4 years ago

Quite true. It only really tests that the playbook runs idempotently, not that it works, per-se.

stale[bot] commented 3 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] commented 3 years ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.