search

geerlingguy / ansible-role-varnish

Ansible Role - Varnish HTTP accelerator
https://galaxy.ansible.com/geerlingguy/varnish/
MIT License
80 stars 88 forks source link

Created new variables in role #103

Closed choukimasri closed 3 years ago

choukimasri commented 3 years ago

Fixes #102

geerlingguy commented 3 years ago

@choukimasri - This change looks great, but the one thing that's missing before I can merge it is documentation of all these new variables in the README file.

Also, it seems the build is failing due to some yaml errors in the changes.

choukimasri commented 3 years ago

@geerlingguy I wasn't able to trigger travis but I think it would build now.

choukimasri commented 3 years ago

@geerlingguy hey!, the bot informed me that the pull request is stalling, magically I closed and reopened it and travis was triggered, now after all seems ok, would you be able to merge it ?

Best regards

stale[bot] commented 3 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 3 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.