search

geerlingguy / ansible-role-varnish

Ansible Role - Varnish HTTP accelerator
https://galaxy.ansible.com/geerlingguy/varnish/
MIT License
81 stars 89 forks source link

Ubuntu 16.04 is not enabling at boot #64

Closed andrewhowdencom closed 7 years ago

andrewhowdencom commented 7 years ago

Stub issue. I'm looking at this now, and will write what I find here for future people.

andrewhowdencom commented 7 years ago

There is both a systemd service unit and a sysvinit bash script. I think ansible might be enabling the bash script somehow, by precedence.

andrewhowdencom commented 7 years ago

Moving the sysvinit script out the way means the systemd service is enabled on boot. Just gonna try it the other way

andrewhowdencom commented 7 years ago

Perhaps related: https://github.com/ansible/ansible/issues/22303

andrewhowdencom commented 7 years ago

Potential workaround: https://github.com/ansible/ansible-modules-core/issues/3764#issuecomment-284331673

andrewhowdencom commented 7 years ago

Might be resolved by https://github.com/geerlingguy/ansible-role-varnish/pull/65. Just testing.

andrewhowdencom commented 7 years ago

Yah it worked. Using our fork for now -- if this gets merged in, awesome. <3

geerlingguy commented 7 years ago

Thanks for the PR! I left a couple review notes.

andrewhowdencom commented 7 years ago

Hola! Thanks for getting back to me. I've amended the review, and am running a test build now as a sanity check (though I have used this syntax previously).

As a design note, would you consider adding a .yamllint file to the top of your repo? This would make code style nits such as EOL easier to catch in future

andrewhowdencom commented 7 years ago

Booted fine

geerlingguy commented 7 years ago

This is fixed via the merged PR now. Thanks!