search

geerlingguy / ansible-role-varnish

Ansible Role - Varnish HTTP accelerator
https://galaxy.ansible.com/geerlingguy/varnish/
MIT License
80 stars 89 forks source link

Varnish < 6.1, problem with varnish.service.j2 on Debian 9 Stretch #87

Closed gdelafond closed 4 years ago

gdelafond commented 5 years ago

Hello,

Reload does not work anymore on Debian Stretch with varnish 4.1.10 (and I think any version < 6.1).

In commit e0b24126f28455533bd2b3f42c9843fbe16f5976 ExecReload has been set to /usr/sbin/varnishreload instead of /usr/share/varnish/reload-vcl. With Varnish 4.1.10 on Debian Stretch, varnishreload does not exists.

I think varnishreload has been added in packages for the 6.1 version and the ExecReload line should be: 

ExecReload={% if varnish_version | version_compare('6.1', '<') %}/usr/share/varnish/reload-vcl{% else %}/usr/sbin/varnishreload{% endif %}

Thank you

gdelafond commented 5 years ago

Hello,

@geerlingguy If I do a PR for this, are you willing to accept it?

Thank you

stale[bot] commented 4 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] commented 4 years ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.