search

geerlingguy / ansible-role-varnish

Ansible Role - Varnish HTTP accelerator
https://galaxy.ansible.com/geerlingguy/varnish/
MIT License
80 stars 88 forks source link

Listen protocol not configurable #98

Closed fhebert-ehess closed 3 years ago

fhebert-ehess commented 3 years ago

It would be great to be able to specify the listening protocol of varnishd (-a switch).

A new variable would be necessary : varnish_listen_protocol and the ExecStart line of systemd service would be modified as :

varnish.service.j2 : ExecStart=/usr/sbin/varnishd -a {{ varnish_listen_address }}:{{ varnish_listen_port }},{{ varnish_listen_protocol }} -T {{ varnish_admin_listen_host }}:{{ varnish_admin_listen_port }}{% if varnish_pidfile %} -P {{ varnish_pidfile }}{% endif %} -f {{ varnish_config_path }}/default.vcl -S {{ varnish_config_path }}/secret -s {{ varnish_storage }} {{ varnishd_extra_options }}

Also in varnish.params.j2 : a new option : VARNISH_LISTEN_PROTOCOL={{ varnish_listen_protocol }}

Bilge commented 3 years ago

This is still not sufficient. Look at the documentation for -a and you can see there are far more options available, including user, group, and mode. Moreover, Unix domain sockets can be used, which don't specify address or port. But more importantly, -a can be specified multiple times and this role has absolutely no provision for that facility. The current implementation is incredibly short-sighted.

stale[bot] commented 3 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] commented 3 years ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.