geerlingguy / ansible-role-varnish

Ansible Role - Varnish HTTP accelerator
https://galaxy.ansible.com/geerlingguy/varnish/
MIT License
80 stars 88 forks source link

Fixes #68: Also remove old unit file if it exists for RedHat #99

Closed Maksold closed 3 years ago

Maksold commented 3 years ago

I had problem with unit file update and a result found a solution in setup-Debian file. Then I added the same code to setup-RedHat. Tested on CentOS 7.

stale[bot] commented 3 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 3 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

Maksold commented 3 years ago

@geerlingguy Could you please accept my changes, because there is a small fix?

geerlingguy commented 3 years ago

I typically run containers (which are built fresh in a new image each time), or rebuild a server with new versions—I think since this would be a one-off fix, it would be better to (at this point, at least) just add that task in a playbook or run it one-off with an ad-hoc command.