search

geerlingguy / drupalci-sonar-jenkins

DEPRECATED - Drupal CI environment with SonarQube and Jenkins for Drupal Core code analysis.
41 stars 16 forks source link

Support Vagrant plugins: auto_network, hostsupdater, hostmanager #22

Closed scottrigby closed 7 years ago

scottrigby commented 7 years ago

Re 927a09a, I renamed the host_vars file to match the host name per Ansible docs Inventory > Splitting Out Host and Group Specific Data.

scottrigby commented 7 years ago

The only other hard-coded reference to the Vagrant IP is in provisioning/inventory-local. I'm trying to read up on it in Ansible docs, but it's not clear yet how to make that dynamic. Pretty sure since this is ini-style the inventory file can't be parameterized, like:

diff --git a/provisioning/inventory-local b/provisioning/inventory-local
index f058f3c..1e8f52a 100644
--- a/provisioning/inventory-local
+++ b/provisioning/inventory-local
@@ -1,2 +1,2 @@
 [drupalci]
-192.168.99.9
+"{{ vagrant_ip }}"

It seems that this file is just for a bit of provisioning speed, to skip the auto-provisioning step, so I'm thinking this PR should delete that file. I'll do as a separate commit.

geerlingguy commented 7 years ago

Thanks for this!