geerlingguy / internet-pi

Raspberry Pi config for all things Internet.
MIT License
4.15k stars 440 forks source link

Port 80 #543

Closed iamagithublearner closed 4 months ago

iamagithublearner commented 10 months ago

Hey i wanted to ask if i can run this on a pi which is already running as a NAS (OMV) , or do i NEED to have a seperate pi for this? while installing this , i realized this will run on default port 80? but thats also being used by OMV, i am not sure how that will work if i start both at same time, please let me know what i can do about this

jerzerisz commented 10 months ago

You certainly can run this on a pi or other computer running other containers/services.

What you'll need to do is edit one of: /templates/docker-compose.yml.j2 /templates/pi-hole-docker-compose.yml.j2 /templates/docker-compose.yml.j2 /templates/shelly-plug-docker-compose.yml.j2 /templates/starlink-docker-compose.yml.j2

you'll want to find a section like ports:

iamagithublearner commented 10 months ago
TASK [Ensure internet-monitoring environment is running.] *******************************************************************************************************************************************************
fatal: [127.0.0.1]: FAILED! => {"changed": false, "msg": "Error connecting: Error while fetching server API version: ('Connection aborted.', PermissionError(13, 'Permission denied'))"}

PLAY RECAP ******************************************************************************************************************************************************************************************************
127.0.0.1                  : ok=11   changed=1    unreachable=0    failed=1    skipped=8    rescued=0    ignored=0

hey i get this error, i tried rebooting too

jerzerisz commented 10 months ago

are you running this on the pi you're installing to? if so

can you run: docker ps

That will verify if you have docker running and your user has correct permissions to run docker commands, which would lead me to suspect an issue in your inventory.ini file.

iamagithublearner commented 10 months ago

image docker ps returns this , seems like its no running?

jerzerisz commented 10 months ago

yep docker is running, do you have to run sudo? that might indicate a permissions issue

edit: Noticed the non default user dead, have you edited the inventory.ini file to use this user instead of the default pi user?

see: https://github.com/geerlingguy/internet-pi/pull/528/files

iamagithublearner commented 10 months ago

oh that worked, thanks! but now i have a new error image

jerzerisz commented 10 months ago

Awesome.

Now we've circled back to the original issue.

Important bits are: 0.0.0.0:80: bind: address already in use

double check you updated the port mapping.

iamagithublearner commented 10 months ago

yeah my docker-compose.yml.j2 file looks like this

....
services:
{% if domain_name_enable %}
  nginx-proxy:
    image: nginxproxy/nginx-proxy:latest
    restart: always
    ports:
      - "3080:80"
    networks:
      - back-tier
      - front-tier
    volumes:
      - /etc/localtime:/etc/localtime:ro
      - /var/run/docker.sock:/tmp/docker.sock:ro
{% endif %}
....
iamagithublearner commented 10 months ago

this is the only thing i changed , couldnt find more references of port 80:80

jerzerisz commented 10 months ago

Ok, That section is if you're using the nginxproxy feature, a little more advanced feature, i don't believe you're using. The line we're looking for is little different than i was expecting.

in the file: pi-hole-docker-compose.yml.j2

services: pihole: container_name: pihole image: pihole/pihole:latest restart: unless-stopped hostname: '{{ pihole_hostname }}' ports:

this - "80:80/tcp" is the line to change, the /tcp or /udp is specifying what protocol to map the port

iamagithublearner commented 10 months ago

oh , thanks! , so i should undo the changed i made earlier? for the nginxproxy ? i am not using it anyways

iamagithublearner commented 10 months ago

do i need to restart ansible or smth? image

iamagithublearner commented 10 months ago

@jerzerisz can you please check this?

github-actions[bot] commented 6 months ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] commented 4 months ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.