geerlingguy / internet-pi

Raspberry Pi config for all things Internet.
MIT License
4.29k stars 449 forks source link

Resolve dependency issues from Debian Bookwrom and improve resolvconf update #565

Closed cwille97 closed 8 months ago

cwille97 commented 10 months ago

This PR primarily intends to fix a problem that was introduced in Debian Bookworm, which broke the Ansible playbook. While setting this up on a Pi with the latest image, I was able to troubleshoot the pip dependency issues and replace them with apt. Additionally, my Pi did not have resolvconf installed which caused Ansible to blow up, so I added that to the Debian dependencies, and also used Ansible to create the resolvconf.conf file if it does not exist. Finally, I made a few tweaks in the README to fix a typo, reflect the current admin portal for Pihole, and update the setup instructions to fix the pip issue.

Note

cwille97 commented 10 months ago

@geerlingguy Would love to get a review on this so that we can fix the main setup here for anybody coming with a fresh Pi OS installation 🚀

geerlingguy commented 10 months ago

I highly recommend using pip to install Ansible instead of apt. The maintenance of the Debian ansible repositories has been hit or miss over the years, and Pip is the source of truth for a full ansible install.

The better solution will be to follow this guide and get Debian to not be so persnickety.

cwille97 commented 10 months ago

@geerlingguy That makes sense, thanks for sharing. I'll try and push an update to the PR if I find time.