geerlingguy / internet-pi

Raspberry Pi config for all things Internet.
MIT License
4.29k stars 449 forks source link

Angular deprecation affects 'Node Exporter' Grafana dashboard #588

Closed falkecarlsen closed 3 months ago

falkecarlsen commented 6 months ago

https://grafana.com/docs/grafana/latest/developers/angular_deprecation/

mschirrmeister commented 6 months ago

You can change the uptime panel from Statusmap to Status history for a test. Here is an example what I currently have in a modified dashboard.

grafana_status_history

I did also set the Max data points to 365 (no idea what an ideal value is). Otherwise it was choking. Similar to other panels with certain time ranges, where it cannot display data.

At least it still looks similar and ok. But don't know if it is an appropriate one. Will be interesting what @geerlingguy has in mind for a new panel type. 😎

martinbrose commented 4 months ago

Seems to be now a problem that breaks this overview: Screenshot 2024-06-01 at 16 49 00

Running grafana/grafana:latest, just pulled and it's the version that was pushed 4 days ago.

quadespresso commented 4 months ago

fwiw: https://github.com/geerlingguy/internet-pi/issues/598#issuecomment-2141068063

martinbrose commented 4 months ago

Thanks @quadespresso,

we might just need to raise a pull request to fix this real quick with your interim solution... Do you want to raise one?

Cheers

quadespresso commented 4 months ago

Sure thing, @martinbrose. Is it just a simple matter of exporting my dashboard?

I'll dig around to see if I can figure out whether it's as straightforward as that, or something considerably less verbose.

quadespresso commented 3 months ago

fyi my comments here might cross over into #598 (and vice-versa). Adding @mschirrmeister to this thread for visibility. And @butchkemper as well, due to them accepting my suggestion absent additional scrutiny.

So I exported my dashboard and diff'd against https://github.com/geerlingguy/internet-pi/blob/4.0.0/internet-monitoring/grafana/provisioning/dashboards/internet-connection.json and found a fair number of other things have been updated as well.

I'm happy to file a PR with this change. But the PR may well impact other facets of the dashboard, for better or for worse.

I suppose I could phrase it as "2024-06 Internet Connection dashboard update" and include a mention of the plugin update for the Uptime panel plugin? The very nature of "includes other random things you probably didn't ask for" grates against my own sensibilities.

Let me know your thoughts. I can always set up the PR, and we can continue the discussion there.

quadespresso commented 3 months ago

PR created for discussion: https://github.com/geerlingguy/internet-pi/pull/599

geerlingguy commented 3 months ago

Should be fixed now, let me know if not!

DWomack commented 3 months ago

Hey Jeff how 'bout fixing your internet-monitoring? I use it instead of internet-pi. I already have a pi running docker compose.

Thanks

Dennis