Closed quadespresso closed 2 weeks ago
If I can get one or two people to take a look, and see if this PR will not break things, happy to merge to get things updated! And if you see it works and I haven't looked in a few days please ping me directly.
One data point, everything looks good on the one I spun up on a spare pi (In a closet on wifi to excuse the terrible stats lol) :
@hockeygoalie35 could you also try zooming way out on the timeline, to see if things go pear-shaped?
Likewise, could you try zooming in on smaller samples? For example, on that really skinny bar of red in the Uptime graph you shared in your screenshot, zoom way in until it looks something like this:
then select a range of time that falls neatly within the entire Down (red) block, such that when it zooms it looks like this:
Hopefully you get something equally sane in your Uptime view...?
I’ll give it a spin tonight and revert back.
@quadespresso Sure, I updated the Grafana image on my actual running unit and made a new dashboard to get a bigger timescale than the 2 days worth of data on the throwaway pi. And for what it's worth, the other panels function the same, so any changes made didn't affect them.
I tested this on a Debian virtual machine over the weekend and had no issues.
I haven't had the time to do a deep dive into the PR changes. Happy to do this in the next few days if preferred.
@martinbrose thanks for kicking the tires.
Feel free to take a closer look at your leisure. I just want folks to be comfy with the body of changes. I'm quite partial to understanding what each LoC is doing (or in this case, what prompted the changes). But I realise that much of the delta is likely the result of how Grafana works, and that if I try to separate out specifically what I intended to change, it might create extra drag/noise later on as Grafana makes or attempts to make automated adjustments/updates.
Some more data here, I simply replaced the file and worked just fine. Not much but some screenshots.
Thanks for your work guys!
Thanks!
This is essentially an export of my JSON dashboard. Any changes beyond the ones made for the Uptime panel and related plugin were not intentional. A quick look through suggests that some of these may be useful anyway.
That said, I invite folks to try out this dashboard. Where applicable, if you feel there is extra nonsense in this JSON that doesn't belong, let me know.
PTAL @martinbrose, @mschirrmeister, @butchkemper