search

geerlingguy / jeffgeerling-com

Drupal Codebase for JeffGeerling.com
https://www.jeffgeerling.com
GNU General Public License v2.0
40 stars 2 forks source link

Migration resets blog post display to have comment label 'hidden' #51

Closed geerlingguy closed 4 years ago

geerlingguy commented 4 years ago

After every migration, the core.entity_view_display.node.blog_post.default.yml config gets reset:

diff --git a/config/sync/core.entity_view_display.node.blog_post.default.yml b/config/sync/core.entity_view_display.node.blog_post.default.yml
index 0f47228..9918419 100644
--- a/config/sync/core.entity_view_display.node.blog_post.default.yml
+++ b/config/sync/core.entity_view_display.node.blog_post.default.yml
@@ -27,7 +27,7 @@ content:
     third_party_settings: {  }
     region: content
   comment_node_blog_post:
-    label: above
+    label: hidden
     type: comment_default
     weight: 20
     settings:

This causes the 'Comments' label at the top of a blog node's Comments section to get hidden, which is not desired. I think the problem is the way Comments were rendered and displayed in Drupal 7 and the way comment field display values are migrated from Drupal 7 to Drupal 8 mean that there's a little bit of a migration mis-match. In Drupal 7, I definitely don't want individual comments to have a 'Comment' label on it, so I have that hidden. In Drupal 8, the migrated setting comes from an individual comment display to the overall 'Comments' display, and that keeps hiding the 'Comments' label at the top of the comments section.

Since this could be rather annoying to fix automatically, I might go against my better instinct and add this to a list of "things to fix manually after the final migration.

geerlingguy commented 4 years ago

This isn't something dead simple/easy to fix, and rather than spend an hour getting it working in an automated fashion, I'm going to leave it be and fix afterwards via #55.