geerlingguy / kubernetes-101

Kubernetes 101 - by Jeff Geerling
https://kube101.jeffgeerling.com/
MIT License
555 stars 166 forks source link

Episode 6 - Update API version for ingress #29

Closed porkbrain closed 1 year ago

porkbrain commented 3 years ago

Updating apiVersion for networking in episode-06 in drupal-ingress resource to v1 from v1beta1.

Followed answers in these resources to achieve equivalent behaviour:

I tested this change with my local cluster (albeit not running drupal). I selected pathType: ImplementationSpecific because that seems to forward the URI to the app where router can decide what to do.


Closes https://github.com/geerlingguy/kubernetes-101/issues/24

geerlingguy commented 3 years ago

Thanks! I'll be taking a look at this in my next pass through the text (working on the transcription into book form currently).

stale[bot] commented 3 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 3 years ago

This pull request is no longer marked for closure.

frob commented 2 years ago

Tested this patch and it worked well.

The ingress is currently broken on a default install of drocker desktop or minikube on macos without this fix.

porkbrain commented 2 years ago

Let me know if there's something you'd like to me to update before merging this PR.

geerlingguy commented 2 years ago

I'll get to it soon™, don't worry :)

If it's 'planned' then I definitely plan on having at it next go-round, but I have to sync the changes with the book text too, so I tend to batch these fixes together every few months.