Is the `sed_path` variable still needed

geerlingguy / mac-dev-playbook

Mac setup and configuration via Ansible.

Other

6k stars 1.77k forks source link

Is the `sed_path` variable still needed #191

Closed dkrutsko closed 4 months ago

dkrutsko commented 10 months ago

Looking into the sudoers task and git blame, I see that sed_path was defined for use in Vagrant. However, I can no longer see any references to this variable. Am I missing something or could these two tasks be removed? https://github.com/geerlingguy/mac-dev-playbook/blob/master/tasks/sudoers.yml#L2-L12

geerlingguy commented 10 months ago

@dkrutsko - Yeah... I don't think they're necessary anymore—I don't use them in any of the roles either. I'd accept a PR to nuke 'em.

github-actions[bot] commented 6 months ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] commented 4 months ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.