search

geerlingguy / raspberry-pi-dramble

DEPRECATED - Raspberry Pi Kubernetes cluster that runs HA/HP Drupal 8
http://www.pidramble.com/
MIT License
1.66k stars 260 forks source link

Cleanup 2 #171

Closed weshouman closed 4 years ago

weshouman commented 4 years ago

Use WS2812 mode and fix naming.

geerlingguy commented 4 years ago

Just wondering about the NUM_OF_LEDS—is that for if you have more than one blinkstick connected to the Pi?

weshouman commented 4 years ago

NUM_OF_LEDS is the number of leds being controlled by the script, the nano stick has 2 leds actually, and due to a limitation in blinkstick's package, using the nano.turn_off() turns off only the first led, thus we have to address all the leds on the device.

weshouman commented 4 years ago

I'm not sure though whether to ship those 2 commits of supporting the 2 leds in raspberry-pi-dramble.j2 or not.

Taking into consideration that I've created another whole package advanced-led-control that eases the control of nano blinksticks to show status over the 2 leds based on callbacks, and we could, may be, add another small script that utilizes it in another .j2 file here if desired.

stale[bot] commented 4 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 4 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.