search

geerlingguy / rpi-clone

A shell script to clone a booted disk on a Raspberry Pi.
https://rpi-clone.jeffgeerling.com/
BSD 3-Clause "New" or "Revised" License
172 stars 10 forks source link

Fixed issue #27 (spaces in label) #28

Open framps opened 1 month ago

framps commented 1 month ago

Added double quotes when the label var is used to allow spaces in labels

geerlingguy commented 1 month ago

Looks reasonable; I haven't seen a label with a space on a Pi ever... but I'm guessing it's more a thing when you are managing volumes by hand and making them human-friendly.

Willing to merge if someone can just confirm it doesn't break the mkfs command

framps commented 1 month ago

Willing to merge if someone can just confirm it doesn't break the mkfs command

From my point of view it's the responsability of the issue creator (@OdinVex) to verify the fix.

OdinVex commented 1 month ago

I don't have spare hardware to test the fix but it does run when issued manually. Looking at the script it does appear correct.