search

geerlingguy / top500-benchmark

Automated Top500 benchmark for clusters or single nodes.
MIT License
159 stars 17 forks source link

Added support for more distros #12

Closed DarkAssassin23 closed 1 year ago

DarkAssassin23 commented 1 year ago

Added native support for RHEL and Arch-based distros.

Tested the following distros in both standalone and cluster configurations, all of which succeeded:

When testing newer distros (Arch and Fedora), I encountered an issue with ATLAS that would cause the configuration step to fail. This was due to grep 3.8 and newer throwing a warning into the output saying 'fgrep: warning: fgrep is obsolescent; using grep -F.' This, in turn, would cause ATLAS to fail to find the information it is looking for and fail to configure properly. I added patch-atlas-src.yml, which fixes this issue on affected systems.

geerlingguy commented 1 year ago

Could you split the patch part out into a separate PR? I would gladly merge the multi-OS support right away but see #15 — I might end up swapping out ATLAS at some point, and I'd rather not merge in the patch functionality just to have to yank it.

DarkAssassin23 commented 1 year ago

Absolutely, I can do that. Just as a heads up, though, without the patch, support for newer versions of Fedora, Arch, Manjaro, and other distros with newer grep versions will still work in regards to dependencies, but when it comes time to configure ATLAS, they will crash. However, if you swap out ATLAS as referenced in #15 this will not be an issue.

geerlingguy commented 1 year ago

Thanks! I'm currently looking at swapping out ATLAS, so I'll hold off merging the other PR until #15 is resolved.