geert-janklaps / cds-launchpad-plugin

Launchpad Plugin for demo / development / testing SAP CAP-based projects
MIT License
12 stars 13 forks source link

fix: Launchpad plugin path: keep namespace #38

Open Regloom opened 5 months ago

Regloom commented 5 months ago

Launchpad plugins path should follow URL approach defined for regular apps as stated in this file below: "cds-plugin-ui5 uses the appid as default route (combination namespace + component)"

geert-janklaps commented 4 months ago

@Regloom : I would suggest to first perform a check to see if cds-plugin-ui5 is loaded before enforcing this convention. (like e.g. https://github.com/geert-janklaps/cds-launchpad-plugin/blob/054ec1bade6d0e91bf8fc8a0ea3c01afcd31205e/src/index.ts#L150C5-L150C80)

This plugin has no hard dependency on cds-plugin-ui5, so we need to make sure that we have backwards compatibility for projects not using cds-plugin-ui5.