search

geert-janklaps / cds-launchpad-plugin

Launchpad Plugin for demo / development / testing SAP CAP-based projects
MIT License
12 stars 13 forks source link

Fix generation of config file if several apps internally use same id for their intents #6

Closed the-docta closed 1 year ago

the-docta commented 1 year ago

we have several ui5 apps in same cap project, all (internally) using "intent1" as ID for the intent, which is perfectly valid.

Bug was introduced in 1.0.5 - all apps are generated into one single intent: "intent1", which breaks navigation. Prior to 1.0.5, the app id was used as tile config ids (e.g. "com.sample.app1", "com.sample.app2")

Fixed in this pull request. new tile config id is a combination of the app id and tile config id. e.g. "com.sample.app1-intent1", "com.sample.app2-intent1")

(second commit in the PR just replaces most of the let declarations by const (where appropriate))

geert-janklaps commented 1 year ago

Thanks! missed that bug myself! Just published the new version to NPM!