search

geertj / gruvi

Async IO for Python, Simplified
http://gruvi.readthedocs.org/
MIT License
94 stars 12 forks source link

http: Fix bug in connection_lost. #21

Closed mschmitzer closed 7 years ago

mschmitzer commented 8 years ago

The connection_lost handler of the HTTP protocol feeds self._error into the queue, but that is only set by the super-class implementation, which is called afterwards. Enqueue the exception object that is passed to the super-class implementation instead.

This problem causes the caller to receive a HttpResponse object with _message = None.

geertj commented 7 years ago

This has recently been fixed. I also no longer pass the exception to the handler.