geex-arts / django-jet

Modern responsive template for the Django admin interface with improved functionality. We are proud to announce completely new Jet. Please check out Live Demo
https://github.com/jet-admin/jet-bridge
GNU Affero General Public License v3.0
3.55k stars 775 forks source link

Duplicate app label name with django-oscar dashboard #90

Open SalahAdDin opened 7 years ago

SalahAdDin commented 7 years ago

Ok, i foun this error installing django-oscar and django-jet in same project.

./manage.py runserver                                                                                                 ✓  1567  11:22:45 
Unhandled exception in thread started by <function check_errors.<locals>.wrapper at 0x7febb8eafd90>
Traceback (most recent call last):
  File "/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/django/utils/autoreload.py", line 226, in wrapper
    fn(*args, **kwargs)
  File "/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/django/core/management/commands/runserver.py", line 109, in inner_run
    autoreload.raise_last_exception()
  File "/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/django/utils/autoreload.py", line 249, in raise_last_exception
    six.reraise(*_exception)
  File "/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/django/utils/six.py", line 685, in reraise
    raise value.with_traceback(tb)
  File "/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/django/utils/autoreload.py", line 226, in wrapper
    fn(*args, **kwargs)
  File "/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/django/__init__.py", line 18, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/django/apps/registry.py", line 89, in populate
    "duplicates: %s" % app_config.label)
django.core.exceptions.ImproperlyConfigured: Application labels aren't unique, duplicates: dashboard

I solved this and i'll make pr for it.

contactr2m commented 7 years ago

Thank you for this great project, Any update on this #90 issue?? I see merge #91 did not go well. Dashboard is really very common name. Explicit name would be good. I have done modification at project level but it would be good to have this in master branch..

Keep up the great work. cheers

SalahAdDin commented 7 years ago

@f1nality Many release versions and this bug still present:

./manage.py runserver                                                                                     ✓  886  15:12:22 
Unhandled exception in thread started by <function check_errors.<locals>.wrapper at 0x7fae6a8190d0>
Traceback (most recent call last):
  File "/home/salahaddin/Proyectos/E-Commerce/base/lib/python3.6/site-packages/django/utils/autoreload.py", line 226, in wrapper
    fn(*args, **kwargs)
  File "/home/salahaddin/Proyectos/E-Commerce/base/lib/python3.6/site-packages/django/core/management/commands/runserver.py", line 113, in inner_run
    autoreload.raise_last_exception()
  File "/home/salahaddin/Proyectos/E-Commerce/base/lib/python3.6/site-packages/django/utils/autoreload.py", line 249, in raise_last_exception
    six.reraise(*_exception)
  File "/home/salahaddin/Proyectos/E-Commerce/base/lib/python3.6/site-packages/django/utils/six.py", line 685, in reraise
    raise value.with_traceback(tb)
  File "/home/salahaddin/Proyectos/E-Commerce/base/lib/python3.6/site-packages/django/utils/autoreload.py", line 226, in wrapper
    fn(*args, **kwargs)
  File "/home/salahaddin/Proyectos/E-Commerce/base/lib/python3.6/site-packages/django/__init__.py", line 27, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/home/salahaddin/Proyectos/E-Commerce/base/lib/python3.6/site-packages/django/apps/registry.py", line 89, in populate
    "duplicates: %s" % app_config.label)
django.core.exceptions.ImproperlyConfigured: Application labels aren't unique, duplicates: dashboard
Quit the server with CONTROL-C.
edx.devstack.lms | Traceback (most recent call last):
edx.devstack.lms |   File "/edx/app/edxapp/edx-platform/manage.py", line 112, in <module>
edx.devstack.lms |     startup.run()
edx.devstack.lms |   File "/edx/app/edxapp/edx-platform/lms/startup.py", line 51, in run
edx.devstack.lms |     django.setup()
edx.devstack.lms |   File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/django/__init__.py", line 18, in setup
edx.devstack.lms |     apps.populate(settings.INSTALLED_APPS)
edx.devstack.lms |   File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/django/apps/registry.py", line 89, in populate
edx.devstack.lms |     "duplicates: %s" % app_config.label)
edx.devstack.lms | django.core.exceptions.ImproperlyConfigured: Application labels aren't unique, duplicates: dashboard
edx.devstack.lms | Traceback (most recent call last):
edx.devstack.lms |   File "/edx/app/edxapp/edx-platform/manage.py", line 112, in <module>
edx.devstack.lms |     startup.run()
edx.devstack.lms |   File "/edx/app/edxapp/edx-platform/lms/startup.py", line 51, in run
edx.devstack.lms |     django.setup()
edx.devstack.lms |   File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/django/__init__.py", line 18, in setup
edx.devstack.lms |     apps.populate(settings.INSTALLED_APPS)
edx.devstack.lms |   File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/django/apps/registry.py", line 89, in populate
edx.devstack.lms |     "duplicates: %s" % app_config.label)
edx.devstack.lms | django.core.exceptions.ImproperlyConfigured: Application labels aren't unique, duplicates: dashboard
Ismael-VC commented 6 years ago

Please come to the django-jet Discord server so we can organize if you like:

Welcome! 😄

SalahAdDin commented 6 years ago

It's solved in my fork.

sfdye commented 6 years ago

+1, I have an app named dashboard in my project and now I can't use jet.

SalahAdDin commented 6 years ago

I made a PR but... @f1nality

solvire commented 6 years ago

Would be nice to have this one fixed. Should be easy enough given there is an open PR on it.

SalahAdDin commented 6 years ago

I think there is more than one PR but @f1nality does not merge it.

solvire commented 6 years ago

It should be a fairly simple fix... In my app I renamed my dashboard using something similar to what you did in your PR. Thanks for that.

If he sees this thread - I purchased a commercial license if that helps with motivation. :)

SalahAdDin commented 6 years ago

@solvire I did the PR, yes, but @f1nality did never merge it.