Review Templates - Githubissues

geez0x1 / CompliantJointToolbox

Compliant Joint Toolbox (CJT) for MATLAB and Simulink

GNU General Public License v3.0

38 stars 14 forks source link

Review Templates #4

Closed joernmalzahn closed 8 years ago

joernmalzahn commented 8 years ago

Are all template files really necessary? Or are some obsolete?

getStateSpace.m can be implemented in genericJoint class
getNonlinearDynamics_multiple.m and getNonlinearDynamics.m seem to be redundant

geez0x1 commented 8 years ago

You're right on getStateSpace(). The other ones were introduced to ease the development of the jointBuilder a bit; it should be possible to merge getNonlinearDynamics and getNonlinearDynamics_multiple. I've assigned this bug to me.

geezIIT commented 8 years ago

getStateSpace() has been removed and is implemented in genericJoint. As for the nonlinear dynamics implementations, all three files:

getNonlinearDynamics
getNonlinearDynamics_multiple
getNonlinearDynamics_none

have been merged into a single getNonlinearDynamics template. Thus marking this as solved.